Updated package.json structs and populated new main field #1151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1009 discusses how the generated
package.json
should have amain
entry regardless of target type, this has been confirmed by a member of the NodeJS module team.Added
main
field to NoModulesPackage and ESModulesPackage in the generated package.json.Cloned the entry filename during struct instantiation for when the
package.json
is generated. Cloning might not be optimal, it is probably possible to borrow theString
and generate the filename with that, but I think clones here should be fine.rustfmt
installedcargo fmt
on the code base before submitting