Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Tail Call Proposal #272

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Support the Tail Call Proposal #272

merged 2 commits into from
Sep 10, 2024

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Sep 1, 2024

This adds support for the Tail Call proposal.

This adds support for the Tail Call proposal.
@guybedford
Copy link
Collaborator

Thanks for posting, let me know when it is ready to review with tests and I'd be happy to approve and release further.

@CryZe CryZe marked this pull request as ready for review September 9, 2024 23:54
@CryZe
Copy link
Contributor Author

CryZe commented Sep 9, 2024

I added roundtrip tests for both instructions. I'm not sure if this is sufficient or if you are looking for more tests. The test infrastructure also seems a bit confusing, so I wasn't entirely sure on how to make it fully work and what tests are generally needed here.

@guybedford guybedford merged commit fd7ea7b into rustwasm:main Sep 10, 2024
8 checks passed
@CryZe CryZe deleted the tail-calls branch September 10, 2024 00:12
@CryZe
Copy link
Contributor Author

CryZe commented Sep 10, 2024

Nice, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants