Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: complete support memory64 proposal #270

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jul 9, 2024

Types Changes

  • Change the definition of DataKind
    • remove ActiveData and ActiveDataLocation

Spec-tests changes

In the spec-tests, running wast2json to generate test cases was the first step. But it usually failed for proposals' wast files.
The reason is wast2json as a part of wabt project is slow to support new proposals.

Fortunately, the wasm-tools project recently provides a json-from-wast subcommand which support new proposals much better.

@lwshang lwshang marked this pull request as ready for review July 9, 2024 18:08
.github/workflows/main.yml Show resolved Hide resolved
@guybedford guybedford merged commit fb53f15 into rustwasm:main Jul 9, 2024
8 checks passed
@lwshang lwshang deleted the memory64 branch July 9, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants