chore: add a clippy job in CI #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8272e87.
This reverts commit f455d79.
Co-authored-by: Guy Bedford <[email protected]>
|
While this is not a BytecodeAlliance project specifically, BA projects as a general rule don't take clippy PRs or CI jobs. That said I would be happy to apply improvements, but without anything that specifically calls out clippy or clippy conventions (ie the CI job and the clippy attribute). |
If you would like to look at the Gimli upgrade here, posting an immediate 0.22.0 would be fine by me actually, especially given that 0.21.0 has been out for not very long. |
|
I see. I will make another PR which only upgrade dependencies and fix deprecation warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied clippy suggestions.
Also bumped the dev-dependencies to the latest major versions.
gimliNow the only not yet updated dependency in Cargo.toml is
gimli.When trying to upgrade it, I got an deprecation warning about
Dwarf::borrowand it requires more work to get rid of this warning message.Also
gimli::read::Dwarfis in the public API ofwalrus, upgrading major version ofgimliis a breaking change.Since we just released version 0.21.0, I believe it's not the best time to introduce a small change that would necessitate another major release soon.