Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unmaintained dotenv & Co. #1359

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

pinkforest
Copy link
Contributor

@pinkforest pinkforest commented Aug 14, 2022

Closes #1254

@JohnTitor @est31 @8573 would you mind reviewing pls

Should we recommend dotenvy as an alternative or something else as per #1254 (comment) ?

Note: I would be slightly hesistant to proceed with unmaintained when the crate says it is intended to be used only in test / dev env - nonetheless there are associated monorepo dotenv_ crates which don't mention this and seem to be used elsewhere

EDIT: the associated monorepo crates also mention about intended use in dev / test only.

Thx.

@pinkforest pinkforest requested a review from amousset August 14, 2022 09:18
@pinkforest pinkforest added the Unmaintained Informational / Unmaintained label Aug 14, 2022
@8573
Copy link
Contributor

8573 commented Aug 15, 2022

I would not object either (1) to adding this advisory now or (2) to waiting until Dylan-DPC is added as an owner of dotenvy on Crates.io, so that the bus factor is raised.

@pinkforest pinkforest added the Propose-Close Propose-Close label Aug 18, 2022
@pinkforest
Copy link
Contributor Author

pinkforest commented Aug 18, 2022

Both crates imply - and are pretty transparent - that it is not to be used in production environment outside dev or test.

For this reason I would naively propose to close this issue.

I mean should we care about crates which are destined to dev and test only ? Perhaps yes.

Would be keen to hear more opinions as to whether merge or close .. 🤷‍♀️

@pinkforest pinkforest added Feedback Needs more feedback and removed Propose-Close Propose-Close labels Aug 18, 2022
@allan2
Copy link

allan2 commented Aug 23, 2022

Both crates imply - and are pretty transparent - that it is not to be used in production environment outside dev or test.

@pinkforest Hi, I am the maintainer of the dotenvy crate. Also responding to your comment on #1254 here.

As stated on the README, dotenvy is convenient for dev environments. This does not mean that it is not intended for prod.
Some may want to use .env files in dev only, preferring to set env vars in the VM or container in prod. Others may wish to use .env in both dev and prod environments. It's up to the preference of the developer.

Also noting that Dylan-DPC has been added to the repo on Aug 14.

Release v0.15.2 was also put out today. Thanks for your interest in dotenv/dotenvy!

@pinkforest
Copy link
Contributor Author

Okay. Proposing to merge then and let's see if anyone objects.

@pinkforest pinkforest added Propose-Merge Propose-Merge and removed Feedback Needs more feedback labels Aug 27, 2022
@pinkforest
Copy link
Contributor Author

pinkforest commented Aug 30, 2022

Since the maintainers are truly not reachable and this is widely used with no maintenance, we'll merge as nobody is objecting.

Regardless that the crate says it is only for dev/test there is evidence that it is used more than that and we should perhaps advise on that.

Thanks all! If the maintainer comes back or someone picks up dotenv we can withdraw this but we'll recommend dotenvy as actionable fix in the meantime.

Copy link
Member

@amousset amousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given there is a maintained fork this is easily actionable and I agree we should publish these.

@pinkforest pinkforest merged commit e7dcb97 into rustsec:main Aug 30, 2022
@pinkforest pinkforest deleted the add/unmaintained/dotenv branch August 30, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Propose-Merge Propose-Merge Unmaintained Informational / Unmaintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotenv crate is implicitly unmaintained
4 participants