cert: retain parsed Cert serial number. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revocation checking based on certificate revocation lists (CRLs) is done by checking a validated CRL for an end-entity certificate's serial number. In preparation for implementing this we must retain certificate serial numbers when parsing, instead of discarding after reading. We don't attempt to decode the raw serial number as a big integer since for the purpose of revocation checking we can match the ASN.1 encoded form without further processing.
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 93.74% 93.81% +0.07%
==========================================
Files 13 13
Lines 2574 2604 +30
==========================================
+ Hits 2413 2443 +30
Misses 161 161
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revocation checking based on certificate revocation lists (CRLs) is done by checking a validated CRL for an end-entity certificate's serial number. In preparation for implementing this we must retain certificate serial numbers when parsing, instead of discarding after reading.
We don't attempt to decode the raw serial number as a big integer since for the purpose of revocation checking we can match the ASN.1 encoded form without further processing.
Trust anchors will not be checked for revocation using CRLs so we do not augment the
TrustAnchorrepresentation and instead continue to discard the serial number when parsing TAs.Relates to #56