Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files from package #14

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Remove unnecessary files from package #14

merged 2 commits into from
Aug 31, 2023

Conversation

Jake-Shadle
Copy link
Contributor

No description provided.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular motivation for these changes? IIRC some distro packagers like to run tests from the packages.

(Have you ever tried to discuss with the Cargo team whether package.exclude should have a default like this?)

@Jake-Shadle
Copy link
Contributor Author

Ahh, I wasn't aware distro packagers packaged library crates like that, I guess I'll remove that one.

The motivation was mainly that the crate package currently includes the scripts/generate-certificate.sh which is both unnecessary for downstream users, and triggers a new check I'm adding to cargo-deny to resolve EmbarkStudios/cargo-deny#43

@djc
Copy link
Member

djc commented Aug 31, 2023

So are you going to submit PRs for all crates that are upstream of Embark crates? 😄

@djc djc merged commit 79acfd6 into rustls:main Aug 31, 2023
6 checks passed
@Jake-Shadle
Copy link
Contributor Author

Possibly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants