Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.3.4 #129

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Prepare 0.3.4 #129

merged 2 commits into from
Aug 23, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Aug 23, 2024

No description provided.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to do releases for 0.1 and 0.2, too? Should we yank older releases?

@complexspaces
Copy link
Collaborator

I'm in favor of yanking older releases 👍

releases for 0.1 and 0.2, too?

#130 is covering 0.1 (which is what 1P internally uses). I lean towards not patching 0.2 since the crates.io downloads of it seem basically at background noise/bot levels and everyone else is on 0.3.

@djc
Copy link
Member

djc commented Aug 23, 2024

@complexspaces what's blocking 1P from upgrading to newer rustls?

@complexspaces
Copy link
Collaborator

what's blocking 1P from upgrading to newer rustls?

ring for better or worse. We are still stuck on an alpha 0.17 of ring with RSA-OEAP stuff included in it and have not spent significant time internally either migrating to rsa (which has vulns in it at the moment) or contributing upstream to ring to get those changes into a real 0.17 release 😓.

@ctz ctz merged commit f6d492b into main Aug 23, 2024
20 checks passed
@ctz
Copy link
Member Author

ctz commented Aug 23, 2024

See v/0.3.4 and https://crates.io/crates/rustls-platform-verifier/0.3.4

As per the previous release PR, I checked there were no changes in android/ since the last release.

@ctz ctz deleted the jbp-prepare-0.3.4 branch August 23, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants