Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimise features demanded from rustls-webpki crate #103

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Jun 25, 2024

This dependency exists so this crate can access
webpki::Error and webpki::Error::RequiredEkuNotFound, which are unconditionally available.

fixes #102

ctz added 2 commits June 25, 2024 08:49
This dependency exists so this crate can access
`webpki::Error` and `webpki::Error::RequiredEkuNotFound`,
which are unconditionally available.
@ctz
Copy link
Member Author

ctz commented Jun 25, 2024

CI / Test (windows-latest) (pull_request) Failing after 1m

This is also happening on main; added a remedial commit.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctz ctz merged commit 2b3bfbe into main Jun 25, 2024
19 checks passed
@cpu cpu deleted the jbp-minimise-webpki-features branch June 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandatory dependency on ring on unix platforms (including Linux)
3 participants