Remove locking #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
🎶 sad trombone sound 🎶
The justification for this change makes sense to me. I flagged a couple small style nits to take/leave as you want.
One question: I see that the Error::cannot_lock() fn and the Reason::UnableToGetWriteLock variant are left in, was that oversight or for future use?
Will remove that. Thanks! |
This was the wrong direction: coming commits want to call callbacks (which themselves can and do re-enter the API) which would lead to deadlock. Let's just accept that the API we're implementing is not thread safe. I also looked at deferring callbacks to outside the lock scope, but that removes the ability for callbacks to have side effects during the handshake.
cpu
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the wrong direction: coming commits want to call callbacks (which themselves can and do re-enter the API) which would lead to deadlock.
Let's just accept that the API we're implementing is not thread safe.
I also looked at deferring callbacks to outside the lock scope, but that removes the ability for callbacks to have side effects during the handshake.