Basic server support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring use of `Bio::new_pair(Some(a), Some(a))` to donate two refs of `a` is not what is required by `SSL_set_bio`. Instead make an object backed by `BIO_s_null()`, and then call `update()` on it.
ctz
force-pushed
the
jbp-basic-server-support
branch
from
ebed86a to
9c13e8e
Compare
cpu
reviewed
Apr 11, 2024
cpu
reviewed
Apr 12, 2024
We mishandled non-blocking writes in several respects: - `SSL_get_error()` would say to retry the read if the write BIO was the same as the read BIO. - raise the correct `io::Error` in `impl io::Write for Bio`. - the current IO `Want` was was ignored: give `Want::write` primacy because rustls tends to always want to read in idle conditions (for alert receipt).
ctz
force-pushed
the
jbp-basic-server-support
branch
from
9c13e8e to
0b6fc8b
Compare
Because `SSL_CTX_use_PrivateKey` implies we have to use an `EVP_PKEY` as-is, `evp_pkey.rs` implements a wrapper over OpenSSL `EVP_PKEY`s, and `sign.rs` uses that wrapper to implement `rustls::sign::SigningKey` and `Signer` traits.
These should not be put on the openssl error stack, and should not be logged either.
Engineer a typical case: the server requires auth, but the client has no credentials. To make this work: - match `SSL_read` return code (docs say <= 0, implementation does 0, we chose -1 previously). - print (and therefore validate against openssl) ERR_peek_error(). - ensure the error from rustls is the one that is propagated (by retrieving it from `process_new_packets()`) rather than one already wrapped in `std::io::Error`.
"SSL_set_SSL_CTX is a bad idea" says the openssl issue tracker :)
This is for new APIs around alerts from server `Acceptor`.
Plus the `SSL_CTX` equivalents.
ctz
force-pushed
the
jbp-basic-server-support
branch
from
0b6fc8b to
0a50edf
Compare
cpu
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of bug-fixes and server groundwork from the nginx branch. Along the way, client auth starts to work & is tested.
At the end of this branch the basic test of server behaviour
tests/server.cis passing.