-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 24.04 & Nginx 1.24.0 compat work #20
Conversation
Correct killing of docker process using `--init`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final 4 commits lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't "approve" since I opened the PR, but I've reviewed the early commits and do approve ☑️ Just one comment to ask about.
Ensure limitations on ID contexts are applied.
Similar to the already implemented `SSL_get_version()`, but returning the IANA registered protocol identifier constant as an `int`, instead of its name as a `*char`.
Trying to avoid a second test instance run after the first encountering an error of the form: ``` Bind for 0.0.0.0:8443 failed: port is already allocated. ```
This is from an optional package. Instead rely on sh and /etc/lsb-release.
e974b84
to
7e2202d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest diff LGTM
|
Thanks for the note, appreciated :-) We should look at adding that in to CI. |
I started on this, but I think I'm bumping into the issue described in actions/runner-images#9959 My 24.04 runs (exemplar) are dying in an early job step running
I'll keep an eye on that upstream issue and try again once it has been resolved. |
FWIW I rolled this into #29 because I needed nginx 1.24+ for an integration test in that branch. |
Ctz and I both riffed on this branch, working towards initial support for Nginx on Ubuntu 24.04.
At a high-level this involves:
SSL_SESSION
manipulation APIsSSL_get_SSL_CTX
SSL_version
SSL_CONF_*
API surface (this will likely deserve revisiting soon to implement some config manipulation we could support)SSL_sendfile
(this is kTLS specific in the OpenSSL API)With these changes in place the Nginx 1.24.0 install is operable in a basic form with Rustls acting as libssl.