-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Makefile: only use ASAN for debug+clang
Previously if `$CC` was `clang` the `Makefile` would configure `CFLAGS` and `LDFLAGS` with address sanitizer (ASAN) enabled. We only want this to happen for _debug_ builds that are using `clang`, since it's generally considered bad practice to ship sanitizer builds as release artifacts. This commit updates the logic to require `PROFILE=debug`, and then switches CI to use that profile when running tests. The Valgrind test continues to use `PROFILE=release` because ASAN and Valgrind will conflict, raising the error "ASan runtime does not come first in initial library list;". It may be possible to use both with more care/configuration, but for now we'll just use valgrind with a release build.
- Loading branch information
Showing
3 changed files
with
13 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#!/usr/bin/env bash | ||
openssl s_server \ | ||
-cert test-ca/rsa/end.cert \ | ||
-cert_chain test-ca/rsa/inter.cert \ | ||
-key test-ca/rsa/end.key \ | ||
-alpn "hello,world" \ | ||
-accept localhost:4443 \ | ||
-rev |