load_certs_from_path

[0rphon]

This PR offers a solution for #147 by moving CertPaths::load to the public function load_certs_from_path

[djc]

This seems reasonable to me.

[djc]

Maybe paths instead of path? Also I would spell this as file: Option<impl AsRef<Path>>, dir: Option<impl AsRef<Path>> since there is no reason to require that both types are the same.

[0rphon]

If you use impl here then the caller has to manually specify a type any time they use None for one of the arguments. ie load_certs_from_path(None, Some("/tmp")) would need to be written like load_certs_from_path(Option::<&str>::None, Some("/tmp")), whereas using the same T generic for both means itll auto-resolve as long as at least one argument is Some. I figured that would be less annoying for the caller, but i agree it is more limiting and i can change this to use impl if you think its best!

(edit: accidentally said dyn instead of impl)

[0rphon]

actually now that i think about it more, if the caller is using two different types that satisfy AsRef<T>, then they can just convert them to paths on their end before passing them. which i think is less of a hassle than having to always specify Option::<&str>::None

[djc]

Given this, I'd suggest we just change them both to Option<&Path> and give up on coercion via AsRef. Personally I still don't like that we enforce the same type for both arguments because IMO this suggests something that really doesn't make sense (although it does work it if you just pass &Path, of course).

[cpu]

Thanks for the PR 👍

I think this docs failure in CI could use a fix:

error: unresolved link to `load_certs_from_path`
   --> src/lib.rs:237:[17](https://github.com/rustls/rustls-native-certs/actions/runs/11602445673/job/32333915939?pr=148#step:4:18)
    |
237 |     /// Calls [`load_certs_from_path`] with the given cert paths.
    |                 ^^^^^^^^^^^^^^^^^^^^ no item named `load_certs_from_path` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
    = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

If you wouldn't mind it would also be nice to have the commits squashed down to 1 with a good commit message.

[0rphon]

I believe i addressed everything. I'll let you guys merge this when you think its all good

[cpu]

Thanks! LGTM