Minor github actions updates #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
reviewed
Jan 12, 2024
|
getting feedback that there was a preference to stay on 20.04 explicitly.
I can't find the relevant PR/feedback now, so I could be remembering wrong.
I don't specifically remember giving this feedback but in general I like
for CI configuration to specify explicit versions of things. That reduces
the chance that a PR CI run fails for reasons unrelated to that PR, which
can be very frustrating for new contributors.
That said I don't feel super strongly about it and am happy to prioritize
consistency within the rustls org.
|
👍 Seems reasonable to use ubuntu-latest then. @ctz Do you want to rebase this on |
Closed
This complains: > warning: initializer for `thread_local` value can be made `const` But doing the suggested fix breaks the build on our MSRV, with: > warning: a `const` item should never be interior mutable So we can't really win.
ctz
force-pushed
the
jbp-gh-actions-rev
branch
from
7547856 to
844ea57
Compare
Done |
|
Thanks! 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been stealing some of this config -- these are changes I made "downstream".