Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelog #372

Merged
merged 3 commits into from
Dec 5, 2023
Merged

docs: update changelog #372

merged 3 commits into from
Dec 5, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Dec 3, 2023

This branch adds an updated CHANGELOG.md covering the to-be-published 0.12.0 release. Additionally it fixes one misnamed function caught during review of the changes since the last release, and a fn that was accidentally dropped from the rustls.h interface.

To generate the changelog content I pulled the 0.11.0 src/rustls.h and the src/rustls.h from main, ran them through gcc to remove comments and post-processed to remove whitespace and # lines. I then reviewed the diff and tried to account for all of the changes in the text:

gcc -fpreprocessed -E old.rustls.h | sed '/^\s*$/d' | grep -v '#' > old.h
gcc -fpreprocessed -E src/rustls.h | sed '/^\s*$/d' | grep -v '#' > new.h
diff new.h old.h

When the `rustls_client_config_builder_load_roots_from_file` fn was
moved from the client config builder into the root cert store builder
the name wasn't updated. This commit fixes that and regenerates the
rustls header file.
CHANGELOG.md Outdated Show resolved Hide resolved
cpu added 2 commits December 4, 2023 12:22
For some reason, since adding a lifetime to the `rustls_certificate`
type, the `rustls_certificate_get_der` fn inside the `impl
rustls_certificate` block isn't being picked up by cbindgen, removing it
from the `rustls.h` generated header file.

This commit lifts the fn out of the `impl` block into a free-standing
function, now its properly included in `rustls.h` again.
@cpu cpu force-pushed the cpu-0.12-changelog branch from 35fedfd to 60f5f5f Compare December 4, 2023 17:22
@cpu cpu self-assigned this Dec 4, 2023
Copy link
Collaborator

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsha jsha merged commit a1e41be into rustls:main Dec 5, 2023
21 checks passed
@cpu cpu deleted the cpu-0.12-changelog branch December 6, 2023 15:19
@cpu
Copy link
Member Author

cpu commented Dec 6, 2023

  • Pushed a 0.12.0 tag
  • Created a 0.12.0 GitHub release.
  • Published rustls-ffi v0.12.0 at registry crates-io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants