WIP: track rustls#1628 #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in the change to use `pki_types` for `ServerName`.
This commit takes a patch on an unreleased pki-types commit that adds `ServerName::to_str`. This lets us drop some awkward type massaging in `src/client.rs`.
This commit adjusts rustls-ffi for the updated struct-based `CryptoProvider` work that has yet to land in rustls main.
|
I'm going to close this and try to more meaningfully address provider choice before trying to catch up with unmerged provider changes upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #368 with the minimal set of changes to adapt to rustls/rustls#1628.
This continues the model where we default to
*ring*as the crypto provider, but allow customization of supported ciphersuites. Does not address crypto provider customization (#366).TODO: