client: add ciphersuite and version arrays #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
This looks great, thank you! One interesting thing I noticed:
extern const uint16_t RUSTLS_DEFAULT_VERSIONS[2];
The length of the array is part of the declaration. That feels a little redundant with RUSTLS_DEFAULT_VERSIONS_LEN, but I guess the latter is more convenient that sizeof(RUSTLS_DEFAULT_VERSIONS)/sizeof(uint16_t). The only downside I can see is if someone comes to depend on the latter, and uses a version of the header that is out of date with respect to the library. I think that's fine though.
divergentdave
force-pushed
the
ciphersuite-and-version-arrays
branch
from
ec066b8 to
92e14fd
Compare
|
Whoops, I had gotten the version order wrong at first, and then I only fixed it in one place. |
jsha
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds arrays of ciphersuites and versions as suggested in #165 and #203.