key_pair: emphasize PKCS8 input requirement in constructor fn names #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `KeyPair::from_pem_and_sign_algo` fn expects PKCS8 formatted PEM as input. This commit renames the fn to `Keypair::from_pkcs8_pem_and_sign_algo` to emphasize this, and to pave the way for a more generalized fn to be added in the future.
The `KeyPair::from_der_and_sign_algo` fn expects PKCS8 formatted DER as input. This commit renames the fn to `Keypair::from_pkcs8_der_and_sign_algo` to emphasize this, and to pave the way for a more generalized fn to be added in the future.
djc
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch pulls out the suggested rename from #242 in order to unblock release planning (#236) while the more generic key pair constructor is worked out.