Follow-up from pki-types conversion #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
approved these changes
Mar 15, 2024
djc
force-pushed
the
pki-types
branch
2 times, most recently
from
7fde6a7 to
be21b61
Compare
est31
approved these changes
Mar 16, 2024
I don't think keeping this is valuable since we have a TryFrom impl for PrivatePkcs8KeyDer, which already clearly communicates the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor cleanup after #223. In particular, this converts the CRL generation code to also generate
CertificateRevocationListDerand tries to clarify the documented conversions between&[u8]and the PKI types.cc @Tudyx