basic Ia5String support for DistinguishedName values #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 72.13% 72.86% +0.72%
==========================================
Files 7 7
Lines 1888 1861 -27
==========================================
- Hits 1362 1356 -6
+ Misses 526 505 -21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes the warning: ``` warning: profiles for the non root package will be ignored, specify profiles at the workspace root: package: /home/daniel/Code/Rust/rcgen/rcgen/Cargo.toml workspace: /home/daniel/Code/Rust/rcgen/Cargo.toml ```
Previously the `CertificateParams::write_request` fn duplicated code already present in `write_distinguished_name` for serializing a `DistinguishedName`. This commit replaces the duplicate code with usage of that helper.
This commit updates the `DnValue` enum to add a variant for `Ia5String` values in distinguished names, and adds support for serializing it. These are often used for email address attributes since the printable string type can't contain a `@` character. Note that like existing `DnValue` variants, we accept a `String` but the ASN.1 specification of the encoding constrains allowed values further. Writing a `DnValue::Ia5String` that contains non-ascii characters will panic, similar to how using a `DnValue::PrintableString` with the current code using a value with characters outside of the allowed set will panic. In the future we should consider rewriting the `DnValue` enum to better enforce the character set constraints of each variant at construction time.
This commit updates the logic for converting from the x509-parser distinguished name types into the rcgen equivalent in order to support `Ia5String` values. A small unit test is added that shows round-tripping a certificate with a subject containing an `Ia5String`, serializing it, parsing with x509-parser, and then recreating `CertificateParams` from the DER using `from_ca_cert_der`.
cpu
force-pushed
the
cpu-180-ia5string
branch
from
8891a8c to
eb9bae7
Compare
|
@djc Did you want to give this branch a pass before merge? |
djc
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds basic support emitting and parsing distinguished name values that are Ia5Strings. For example, email address attributes in a certificate subject distinguished name.
Note that because of #181 this code will panic when emitting invalid Ia5String values. This problem is general to rcgen's handling of ASN.1 string types and so isn't addressed with additional care in this branch. A broader rework is required.
Along the way I also fixed a warning from #176 related to where we were defining the custom
profile.dev.package.num-bigint-digprofile metadata.Resolves #180