Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server_name docs #22

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix server_name docs #22

merged 2 commits into from
Dec 8, 2023

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Dec 6, 2023

A missing ``` resulted in incorrectly rendered docs: https://docs.rs/rustls-pki-types/latest/rustls_pki_types/enum.ServerName.html

@rukai rukai force-pushed the fix_server_name_docs branch from 28b6531 to c2ce3f9 Compare December 6, 2023 06:34
djc
djc reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

src/server_name.rs Show resolved Hide resolved
cpu
cpu approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for catching/fixing this 👍

@djc

This comment was marked as resolved.

Sign in to view
@djc djc merged commit a29cd33 into rustls:main Dec 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rukai @djc @cpu