This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Fix blocking in guessing example. #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we await inner the while loop the server will be blocked and can't serve more than one client.
|
Thanks for this patch! -- your thinking here is sound, and we've been thinking about this too for a while! We've come up with a slightly more structural fix by using In itself that's not a great API, so we've started work on #25 to make parallel loop iteration easy to do. Do you feel this would be helpful for you? |
|
@yoshuawuyts OK. I See. Thanks for your explanation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
await?inner the while loop which block the server from serving the next client.Types of changes