Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i8/u8 discrepancy for Language enum #196

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Fix i8/u8 discrepancy for Language enum #196

merged 1 commit into from
Nov 10, 2024

Conversation

DeltaF1
Copy link
Contributor

@DeltaF1 DeltaF1 commented Nov 8, 2024

Closes #195

@DeltaF1 DeltaF1 requested a review from a team as a code owner November 8, 2024 06:56
@Meziu
Copy link
Member

Meziu commented Nov 8, 2024

Wouldn't it be better to change the #[repr()] for the enum rather than converting the values? That representation is made to directly translate the values for the C bindings, it's a bit weird to have them being different from libctru.

@DeltaF1
Copy link
Contributor Author

DeltaF1 commented Nov 8, 2024

Yeah that works too. I initially thought that changing the type might break things in other places, but I just tried it out (master...DeltaF1:ctru-rs:language_repr_2) and it builds fine so I guess nothing was depending on the repr.

@FenrirWolf FenrirWolf merged commit 786af2b into rust3ds:master Nov 10, 2024
4 checks passed
Adair-GA added a commit to Adair-GA/ctru-rs that referenced this pull request Nov 13, 2024
@Adair-GA
Revert "Merge pull request rust3ds#196 from DeltaF1/language_repr"
51e611d 
This reverts commit 786af2b, reversing
changes made to 4a15ec9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FenrirWolf FenrirWolf FenrirWolf approved these changes

@AzureMarker AzureMarker AzureMarker approved these changes

@ian-h-chamberlain ian-h-chamberlain Awaiting requested review from ian-h-chamberlain ian-h-chamberlain is a code owner automatically assigned from rust3ds/active

@Meziu Meziu Awaiting requested review from Meziu Meziu is a code owner automatically assigned from rust3ds/active

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatched types on language enum: expected u8, found i8
4 participants
@DeltaF1 @Meziu @AzureMarker @FenrirWolf