Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up reusable CI workflow and add building doctests #109

Merged
merged 12 commits into from
Apr 17, 2023
Merged

Set up reusable CI workflow and add building doctests #109

merged 12 commits into from
Apr 17, 2023

Conversation

ian-h-chamberlain
Copy link
Member

@ian-h-chamberlain ian-h-chamberlain commented Apr 3, 2023 •
edited
Loading

Part of #106

This does a couple things:

  • Makes sure we are actually building doctests now
  • Switch to using https://github.com/actions-rust-lang/setup-rust-toolchain so we get nice inline warnings and caching
  • Break out some common logic into a reusable composite action. I hope this can also be used for other crates going forward.

@ian-h-chamberlain ian-h-chamberlain requested review from a team, AzureMarker and Meziu April 3, 2023 18:18
@ian-h-chamberlain ian-h-chamberlain marked this pull request as ready for review April 3, 2023 18:18
Meziu
Meziu approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@Meziu Meziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for setting up the CI this way. The more automated checks we have, the easier it is to maintain the repo 👍

AzureMarker
AzureMarker approved these changes Apr 8, 2023
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
Meziu
Meziu approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@Meziu Meziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve made the suggestions to update this PR and merge it.

.github/actions/setup/action.yml Outdated Show resolved Hide resolved
.github/actions/setup/action.yml Outdated Show resolved Hide resolved
@Meziu Meziu merged commit 7e74e2d into master Apr 17, 2023
Meziu added a commit that referenced this pull request Apr 17, 2023
@Meziu
Merge pull request #109 from rust3ds/fix/build-doctests
9b13f9b 
Set up reusable CI workflow and add building doctests
@ian-h-chamberlain ian-h-chamberlain deleted the fix/build-doctests branch April 17, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meziu Meziu Meziu approved these changes

@AzureMarker AzureMarker AzureMarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-h-chamberlain @AzureMarker @Meziu