Implement Send and Sync for softbuffer types #217
Conversation
Previously, types in softbuffer were !Send and !Sync. However it would be nice if types could be shared across threads. Therefore I've made the following changes: - Context<D> is Send+Sync iff D is Send+Sync - Surface<D, W> is Send iff D is Send+Sync and W is Send - Buffer<'x, D, W> is Send iff D if Send+Sync and W is Send Materially, I've made the following changes across the backends: - X11, Wayland and KMS use Arc for their displays instead of Rc. - MacOS uses MainThreadBound to secure windowing resources. This restriction was already implicitly enforced anyhow. - Windows uses a subclassing strategy to manage creating and destroying resources. This subclass is applied to windows that are registered into softbuffer, and is then used to manage resources. Closes #205 Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
|
@jackpot51 Please advise on Redox failures. I'm not familiar enough with Orbital's internals to know if it is thread safe or not. |
|
@jackpot51 Friendly reminder. I'm not familiar enough with Orbital to know how to proceed here. |
@jackpot51 confirmed in chat that Orbital's types should be thread-safe. Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Co-authored-by: Mads Marquart <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
|
It seems that there are still bugs in the Windows backend. Sometimes sending a message to a window on another thread doesn't work. Standby while I investigate. |
This new strategy discards the old subclassing strategy, which led to deadlocks when the main thread was blocked. Instead we instantiate a new thread specifically for creating and destroying DC's. Then we set up a channel so that all DCs are created and then destroyed on that thread. I am open to suggestions as to ways to avoid allocating the new thread. Signed-off-by: John Nunley <[email protected]>
Okay, I've set up a new strategy for multithreading on Windows. It's a little hacky but it seems to work. |
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
|
I think we have approval from all platforms, so I'll go ahead and merge this. But I'll wait a week before releasing, that way the people using the |
Previously, types in softbuffer were !Send and !Sync. However it would
be nice if types could be shared across threads. Therefore I've made the
following changes:
Materially, I've made the following changes across the backends:
restriction was already implicitly enforced anyhow.
Send.Closes #205, still WIP