Bump winit to v0.30 #214
Merged
Bump winit to v0.30 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps winit, which is used in some examples, to version v0.30. This new version comes with many new changes; mainly the move away from closures towards applications. In order to work with this, I create a simple "winit_app" module that allows the examples to simply and easily create winit applications. It takes two closures: one that initializes some state on resume, and another that handles events. I've found this approach reduces diff noise by a lot. Benchmarks still use deprecated functions for now. Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
daxpedda
reviewed
May 5, 2024
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
daxpedda
approved these changes
May 6, 2024
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit bumps winit, which is used in some examples, to version
v0.30.
This new version comes with many new changes; mainly the move away from
closures towards applications. In order to work with this, I create a
simple "winit_app" module that allows the examples to simply and easily
create winit applications. It takes two closures: one that initializes
some state on resume, and another that handles events.
I've found this approach reduces diff noise by a lot.
Benchmarks still use deprecated functions for now.
WIP for now until I test it