Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust.yml #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update rust.yml #38

wants to merge 2 commits into from

Conversation

sagudev
Copy link
Contributor

@sagudev sagudev commented Jul 11, 2021

for #11

@RalfJung RalfJung mentioned this pull request Jul 11, 2021
Merged
RalfJung
RalfJung reviewed Jul 11, 2021
View reviewed changes
.github/workflows/rust.yml
# Runs at 00:10 UTC every day.
- cron: '10 0 * * *'
# Runs at 01:10,02:10,03:10 UTC every day.
- cron: '10 1,2,3 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious, why not "0 1,2,3"? Why those extra 10 minutes? Seems kind of random.^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is random. Most people would use full hours, thus creating a lot of jobs at those times.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC I read in some docs, it is not recommended to use full hours, for the same reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense. Would be good to explain it in the comment. :)

@RalfJung
Copy link
Member

Meanwhile #39 landed; not sure if this one is still needed?

@sagudev
Copy link
Contributor Author

sagudev commented Aug 12, 2021

But it would be still good to try to catch it multiple time in case it is early/late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagudev @RalfJung