Skip to content

Commit

Permalink
chore: bump toolchain
Browse files Browse the repository at this point in the history
  • Loading branch information
calebcartwright committed Dec 29, 2021
1 parent e8afb62 commit 50bbb43
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rust-toolchain
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[toolchain]
channel = "nightly-2021-12-20"
channel = "nightly-2021-12-29"
components = ["rustc-dev"]

3 comments on commit 50bbb43

@murchu27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This toolchain doesn't have rls available - is this intentional? Sorry if this is a silly question, just trying to get my environment set up properly for contributing

❯ rustup component add rls
error: component 'rls' for target 'x86_64-unknown-linux-gnu' is unavailable for download for channel 'nightly-2021-12-29'
Sometimes not all components are available in any given nightly. If you don't need the component, you can remove it with:

    rustup component remove --toolchain nightly-2021-12-29 --target x86_64-unknown-linux-gnu rls

@calebcartwright
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The channel in this file will always be very intentional, but the exact value is driven by requirements not really applicable with standard application usage. Like most of the official tools, rustfmt is heavily reliant on the private compiler internals, so updates to this are based on private compiler APIs as opposed to standard dev loop usage (like component or feature availability).

The RLS availability issue was long lasting, though resolved and unlikely to recur (at least at that duration), so you could try using a newer nightly; this is just reflective of the fact that nothing pre-this channel can be used

@calebcartwright
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if you find you can't use one of the latest nightlies that contain RLS, you can always run the rustup command with the --force flag to tell it to proceed despite the missing component (fwiw you may want to use RA anyway)

Please sign in to comment.