Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit .eh_frame section if using -Cpanic=abort #374

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

antoyo
Copy link
Contributor

@antoyo antoyo commented Oct 27, 2023

No description provided.

@bjorn3
Copy link
Member

bjorn3 commented Oct 27, 2023

.eh_frame is necessary once exceptions reaching into panic=abort rust code starts to abort the program rather than being UB.

@antoyo
Copy link
Contributor Author

antoyo commented Oct 27, 2023

@bjorn3: This is necessary for Rust for Linux.
How do you suggest we handle this?

@bjorn3
Copy link
Member

bjorn3 commented Oct 27, 2023

It may be that this change is fine and once unwinding into panic=abort rust code will abort the presence of the landingpad will cause .eh_frame to be emitted by both cg_llvm and cg_gcc. When that happens whatever solution is chosen for cg_llvm may work for cg_gcc too.

@antoyo antoyo force-pushed the fix/eh-frame branch 2 times, most recently from dea740c to b0353c2 Compare October 27, 2023 12:50
@antoyo antoyo force-pushed the fix/eh-frame branch 2 times, most recently from 02abcb0 to f4d68da Compare October 27, 2023 14:06
@antoyo
Copy link
Contributor Author

antoyo commented Oct 27, 2023

@bjorn3: Do you think this should instead be set/unset depending on the value of -Cforce-unwind-tables?

@antoyo antoyo merged commit 551ea4b into master Nov 8, 2023
65 checks passed
@antoyo antoyo deleted the fix/eh-frame branch November 8, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants