Rustify prepare.sh command #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
build-system
branch
from
a7c0c72
to
91513aa
Compare
bjorn3
reviewed
Aug 18, 2023
bjorn3
reviewed
Aug 18, 2023
GuillaumeGomez
force-pushed
the
build-system
branch
2 times, most recently
from
4202a39
to
f52a4f7
Compare
bjorn3
reviewed
Aug 18, 2023
bjorn3
reviewed
Aug 18, 2023
| Ok(()) | ||
| } | ||
|
|
||
| fn clone_and_setup<F>(repo_url: &str, checkout_commit: &str, extra: Option<F>) -> Result<(), String> |
There was a problem hiding this comment.
The GitRepo struct of cg_clif handles using the github zip archives for much faster downloads when curl is available as well as applying patches and writing a lockfile for reproducibility: https://github.com/bjorn3/rustc_codegen_cranelift/blob/9aa5fbf79c39867f144e5a38c53a8edd2e2069ba/build_system/prepare.rs#L96 For an initial rewrite the current code is fine too.
There was a problem hiding this comment.
Might be nice to have later on indeed.
GuillaumeGomez
force-pushed
the
build-system
branch
8 times, most recently
from
303b4d2
to
0fdf7c6
Compare
GuillaumeGomez
force-pushed
the
build-system
branch
11 times, most recently
from
ef689e9
to
462b928
Compare
GuillaumeGomez
force-pushed
the
build-system
branch
from
462b928
to
c682e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #315.