Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: update comment around close() #133330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

library: update comment around close() #133330

wants to merge 1 commit into from
+11 −10

Conversation

RalfJung
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 22, 2024
@the8472
Copy link
Member

the8472 commented Nov 22, 2024

Yay, progress. Though I think linux may not be compliant with the new spec since it now has specific language for the meaning of EBADF, but that's not relevant to the EINTR issue.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 22, 2024

📌 Commit 729d3aa has been approved by the8472

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Nov 22, 2024
@jieyouxu
Rollup merge of rust-lang#133330 - RalfJung:close, r=the8472
bbc4cbe 
library: update comment around close()

r? `@the8472`
@jieyouxu jieyouxu mentioned this pull request Nov 22, 2024
Open
@ChrisDenton
Copy link
Member

I would only note that we expose OwnedFd on non-POSIX platforms too.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2024
@bors
Auto merge of rust-lang#133339 - jieyouxu:rollup-gav0nvr, r=jieyouxu
a475551 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#133238 (re-export `is_loongarch_feature_detected`)
 - rust-lang#133288 (Support `each_ref` and `each_mut` in `[T; N]` in constant expressions.)
 - rust-lang#133311 (Miri subtree update)
 - rust-lang#133313 (Use arc4random of libc for RTEMS target)
 - rust-lang#133319 (Simplify `fulfill_implication`)
 - rust-lang#133323 (Bail in effects in old solver if self ty is ty var)
 - rust-lang#133330 (library: update comment around close())
 - rust-lang#133337 (Fix typo in `std::thread::Scope::spawn` documentation.)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@the8472 the8472

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @the8472 @bors @ChrisDenton @rustbot