Reimplement ~const trait specialization
#133325
Open
+215
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Nov 22, 2024
| } | ||
|
|
||
| debug!("fulfill_implication: an impl for {:?} specializes {:?}", source_trait, target_trait); | ||
| // If the parent impl is const, then the specializing impl must be const. |
There was a problem hiding this comment.
Note to self: Actually I don't know if this is correct -- well, it's not sufficient.
const trait Bar {}
impl const Bar for T {}
const trait Foo {}
impl const Foo for T where T: ~const Bar {}
// specializing impl:
impl Foo for (T,) {}
The specializing impl satisfies (T,): ~const Bar because of the blanket impl, but it's still less const than the parent impl. I think we need to check that the specializing impl is also conditionally const, and then bail.
|
@rustbot author |
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement const specialization. We need this for
PartialEqconstification :)r? lcnr