Remove legacy bitcode for iOS #133297
Merged
Remove legacy bitcode for iOS #133297
+8
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
DianQK
commented
Nov 21, 2024
| @@ -3412,7 +3409,6 @@ impl Target { | |||
| key!(main_needs_argc_argv, bool); | |||
| key!(has_thread_local, bool); | |||
| key!(obj_is_bitcode, bool); | |||
| key!(forces_embed_bitcode, bool); | |||
| key!(bitcode_llvm_cmdline); | |||
There was a problem hiding this comment.
LLVM still leave some code related to llvmcmd, but I believe this will also be removed in the future.
bjorn3
reviewed
Nov 21, 2024
DianQK
force-pushed
the
embed-bitcode-ios
branch
from
6c5532f
to
ff79a79
Compare
|
These commits modify compiler targets. |
DianQK
force-pushed
the
embed-bitcode-ios
branch
from
ff79a79
to
13e983d
Compare
DianQK
force-pushed
the
embed-bitcode-ios
branch
from
13e983d
to
7cc5fee
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#132730 (std: allow after-main use of synchronization primitives) - rust-lang#133105 (only store valid proc macro item for doc link) - rust-lang#133260 (Constify the `Deref`/`DerefMut` traits, too) - rust-lang#133297 (Remove legacy bitcode for iOS) - rust-lang#133298 (Mention that std::fs::remove_dir_all fails on files) - rust-lang#133384 (add a test for target-feature-ABI warnings in closures and when calling extern fn) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2024
Rollup merge of rust-lang#133297 - DianQK:embed-bitcode-ios, r=nikic Remove legacy bitcode for iOS Follow rust-lang#117364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #117364.