Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Solaris target information, adds Solaris maintainer #133293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updates Solaris target information, adds Solaris maintainer #133293

wants to merge 1 commit into from
+38 −4

Conversation

psumbera
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@psumbera
Copy link
Contributor Author

psumbera commented Nov 21, 2024 •
edited
Loading

Following yesterdays discussion. @cuviper @tgross35 @workingjubilee.

@GuillaumeGomez
Copy link
Member

r? Noratrieb

@rustbot rustbot assigned Noratrieb and unassigned GuillaumeGomez Nov 21, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cuviper
Copy link
Member

cuviper commented Nov 21, 2024

NOTE: if you are adding or renaming a markdown file in a mdBook, don't forget to register the page in SUMMARY.md

workingjubilee
workingjubilee approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah.

@jieyouxu
Copy link
Member

NOTE: if you are adding or renaming a markdown file in a mdBook, don't forget to register the page in SUMMARY.md

Great to see I'm not the only one who forgets about it 😆

jieyouxu
jieyouxu approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great and thank you for signing up to be its target maintainer. I'll tag this with compat relnotes as we're technically changing the baseline -- but previously there was no explicit baseline at all!

@jieyouxu jieyouxu added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 22, 2024
@rustbot rustbot mentioned this pull request Nov 22, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@Noratrieb Noratrieb

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@psumbera @rustbot @GuillaumeGomez @rust-log-analyzer @cuviper @jieyouxu @workingjubilee @Noratrieb