Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use free runners for i686-gnu jobs #133256

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

CI: use free runners for i686-gnu jobs #133256

wants to merge 12 commits into from
+102 −11

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Nov 20, 2024 •
edited
Loading

I'm trying to switch jobs to free runners without impacting the overall time of the auto build.
I don't think we can convert all of them. Let's see.

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 20, 2024
@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
25f24b9 
…<try>

CI: use free runners for 5 linux jobs

try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors
Copy link
Contributor

bors commented Nov 20, 2024

⌛ Trying commit d7063fd with merge 25f24b9...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 20, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2024
@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
c1f0153 
…<try>

CI: use free runners for 5 linux jobs

try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors
Copy link
Contributor

bors commented Nov 20, 2024

⌛ Trying commit c50f770 with merge c1f0153...

@bors
Copy link
Contributor

bors commented Nov 20, 2024

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@MarcoIeni
Copy link
Member Author

image

@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
7e36573 
…<try>

CI: use free runners for 5 linux jobs

try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 3ada89a with merge 7e36573...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 21, 2024

💔 Test failed - checks-actions

@MarcoIeni
Copy link
Member Author

image

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 535184d with merge 940450a...

@MarcoIeni
Copy link
Member Author

I tried to split the jobs in an ugly way, just to test if it's feasible to split the jobs

@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
a023249 
…<try>

CI: use free runners for 5 linux jobs

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 08e429e with merge a023249afa93c2450f672ea5a265339436e06b33...

MarcoIeni
MarcoIeni commented Nov 21, 2024
View reviewed changes
src/ci/github-actions/jobs.yml Outdated
- image: i686-gnu-nopt-2
env:
SCRIPT: >
python3 ../x.py test --stage 0 --config /config/nopt-std-config.toml library/std &&
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3 ../x.py test --stage 0 --config /config/nopt-std-config.toml library/std &&

Maybe we can delete this line since it's already tested above

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 21, 2024

💔 Test failed - checks-actions

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit fc30a49 with merge 18d6348...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
18d6348 
…<try>

CI: use free runners for 5 linux jobs

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 21, 2024

💔 Test failed - checks-actions

@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
9ace94c 
…<try>

CI: use free runners for 5 linux jobs

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 448219e with merge 9ace94cd06cc7bf3c6c11d8ea880c1a9131b700c...

@bors
Copy link
Contributor

bors commented Nov 21, 2024

☀️ Try build successful - checks-actions
Build commit: 9ace94c (9ace94cd06cc7bf3c6c11d8ea880c1a9131b700c)

@MarcoIeni
Copy link
Member Author

MarcoIeni commented Nov 22, 2024 •
edited
Loading

Splitting the tasks in the jobs.yml did't work. So I have now created two new dockerfiles to split the tasks.
Hopefully we find a mechanism to reduce code duplication (of the other docker steps).
E.g. by introducing a way to override the SCRIPT env variable of the dockerfile from the jobs.yml file for example

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 22, 2024

⌛ Trying commit dfb67e7 with merge 1abf837...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
1abf837 
…<try>

CI: use free runners for 5 linux jobs

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@bors
Copy link
Contributor

bors commented Nov 22, 2024

☀️ Try build successful - checks-actions
Build commit: 1abf837 (1abf837664763d8588b93bc70ea37be7d08a470d)

@MarcoIeni
Copy link
Member Author

MarcoIeni commented Nov 22, 2024 •
edited
Loading

Yay, not bad! I'll balance them better
image

@MarcoIeni MarcoIeni changed the title CI: use free runners for 5 linux jobs CI: use free runners for i686-gnu jobs Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarcoIeni @rustbot @bors @rust-log-analyzer @Mark-Simulacrum