Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: split x86_64-mingw job #132721

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

CI: split x86_64-mingw job #132721

wants to merge 28 commits into from
+20 −6

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Nov 7, 2024 •
edited
Loading

I'm trying to split the x86_64-mingw job in two to hopefully move it to free runners and reduce the use of large runners in CI.
If the job is too slow with free runners we could build the artifacts in a large runner and test them in various free runners.

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 7, 2024
@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 7, 2024

⌛ Trying commit 59f649f with merge 5c29c17...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
5c29c17 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 7, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2024
@mati865
Copy link
Contributor

mati865 commented Nov 8, 2024 •
edited
Loading

NO_DOWNLOAD_CI_LLVM: 1 can be removed, I forgot about it when upgrading the toolchain.

That alone should shorten the time by a large amount.

@MarcoIeni
Copy link
Member Author

thanks! I will create a separate PR for this.
This environment variable is present in the following windows jobs:

  • i686-mingw
  • x86_64-mingw
  • dist-i686-mingw
  • dist-x86_64-mingw

Can I delete it for all of them?

@mati865
Copy link
Contributor

mati865 commented Nov 8, 2024

Yeah, they all should be fine to remove.

@MarcoIeni MarcoIeni mentioned this pull request Nov 8, 2024
Closed
@MarcoIeni
Copy link
Member Author

opened #132781 🙏

@MarcoIeni
Copy link
Member Author

Interestingly I found #112645 which does the opposite of this PR. My goal is to try to "revert" part of the PR by using two free runners.
I'll try bors again because I don't get why it failed. Maybe it's a flaky error.

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 14, 2024

⌛ Trying commit a3d3c42 with merge 92e5539...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
92e5539 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 14, 2024

💔 Test failed - checks-actions

@MarcoIeni
Copy link
Member Author

I'll give this one last try 🤔

@MarcoIeni
Copy link
Member Author

@bors try

@mati865
Copy link
Contributor

mati865 commented Nov 14, 2024 •
edited
Loading

This not a spurious failure, the linker is misconfigured.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
89ca439 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Contributor

bors commented Nov 14, 2024

⌛ Trying commit a3d3c42 with merge 89ca439...

@jieyouxu jieyouxu mentioned this pull request Nov 21, 2024
Draft
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#133291 - jieyouxu:exp-rustdoc-gui-test, r=<try>
b898596 
[EXPERIMENT] check npm path on the regular `x86_64-mingw` job

cc rust-lang#132721.
r? `@ghost`

try-job: x86_64-mingw
@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
e7bb551 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit af15021 with merge e7bb5511642c627d9d489654dabd27a51b49a5f9...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 21, 2024

💔 Test failed - checks-actions

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 037bdb1 with merge 90cd28c4f7011ef35026e34de85e4ecdbe36c80c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
90cd28c 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Contributor

bors commented Nov 21, 2024

💔 Test failed - checks-actions

@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
cf0bdf0 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 0a084e3 with merge cf0bdf0...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 21, 2024

💔 Test failed - checks-actions

@jieyouxu jieyouxu self-assigned this Nov 21, 2024
@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 22, 2024

⌛ Trying commit fe76fe4 with merge df838913dc2c22d53f450f99d10a8ca98b1556fc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
df83891 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Contributor

bors commented Nov 22, 2024

☀️ Try build successful - checks-actions
Build commit: df83891 (df838913dc2c22d53f450f99d10a8ca98b1556fc)

@MarcoIeni
Copy link
Member Author

MarcoIeni commented Nov 22, 2024 •
edited
Loading

It didn't work. Maybe it's not possible to do --skip tests/.
image

@jieyouxu jieyouxu removed their assignment Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MarcoIeni @rustbot @bors @rust-log-analyzer @mati865 @Kobzol @Mark-Simulacrum @jieyouxu