Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lint message for ABI not supported #131675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update lint message for ABI not supported #131675

wants to merge 1 commit into from
+57 −57

Conversation

tdittr
Copy link
Contributor

@tdittr tdittr commented Oct 14, 2024 •
edited
Loading

Tracking issue: #130260

As requested in #128784 (review) I updated the error message.

I could also change it to be the same message as if it was a hard error on a normal function:

"{abi} is not a supported ABI for the current target"

Or would that get confusing when people try to google the error message?

r? compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2024
compiler-errors
compiler-errors approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, i can approve once it's re-blessed and ci is green

compiler/rustc_hir_analysis/src/check/check.rs Outdated Show resolved Hide resolved
@compiler-errors
Copy link
Member

remove the backticks, that is :D

@tdittr tdittr force-pushed the update-unsupported-abi-message branch from 0d70dee to b6b6c12 Compare October 14, 2024 08:02
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 14, 2024

📌 Commit b6b6c12 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdittr @compiler-errors @bors @rustbot