Register src/tools/unicode-table-generator
as a runnable tool
#131647
+43
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like
src/tools/unicode-table-generator
is not currently managed by bootstrap. This PR wires it up with bootstrap as a runnable tool.This tool seems to take two possible args:
library/core/src/unicode/unicode_data.rs
, andI only passed the mandatory path to
unicode_data.rs
in bootstrap and didn't do anything about (2). I'm not sure about how this tool is supposed to be run.Cargo.lock
is modified because I renamedunicode-table-generator
's bin name to match the tool name, as bootstrap's tool running logic expects the bin name to be derived from the tool name.I also added a triagebot message to remind to not manually edit the library source file and edit the tool then regenerate instead, but this should probably be a tidy check (if that's desirable then that can be in a follow-up PR and we can drop the triagebot message if desired).
Helps with #131640.
r? @Mark-Simulacrum (since I think you authored this tool?)