Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][PR for CI] refactoring #128974 #131632

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

[WIP][PR for CI] refactoring #128974 #131632

wants to merge 62 commits into from
+2,794 −3,066

Conversation

maxcabrajac
Copy link

Working on #128974
Please ignore

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2024

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in coverage tests.

cc @Zalathar

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustdoc-json Area: Rustdoc JSON backend labels Oct 13, 2024
@maxcabrajac
Copy link
Author

sorry I rebased a little to far and caused this

@maxcabrajac
Copy link
Author

@rustbot -A-meta -A-rustdoc-json

@clubby789 clubby789 removed A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustdoc-json Area: Rustdoc JSON backend labels Oct 13, 2024
@maxcabrajac
Unify visit_variant_discr
0bd8f3f
@maxcabrajac
Unify {visit,walk}_variant
79d50ca
@maxcabrajac
Unify walk_path_segment
fc744bb
@maxcabrajac
Unify walk_qself
5798f37
@maxcabrajac
Unify {visit,walk}_field_def
5b2351a
@maxcabrajac
Unify walk_inline_asm
a4943be
@maxcabrajac
Add mut_only_visit!
0d7a055
@maxcabrajac
Unify walk_local
924326f
@maxcabrajac
Unify {visit,walk}_use_tree
cfda402
@maxcabrajac
Unify {visit,walk}_path
628b7d4
@maxcabrajac
Unify walk_generic_argz
6b8de1d
@maxcabrajac
Unify walk_param_bound
02df8e8
@maxcabrajac
Unify {visit,walk}_precise_capturing_arg
efb1eb8
@maxcabrajac
Unify walk_trait_ref
a04efa6
@maxcabrajac
Unify {visit,walk}_block
370dcb8
@maxcabrajac
Unify walk_pat
5dff2b6
@maxcabrajac
Unify walk_inline_asm_sym
648be35
@maxcabrajac
Unify walk_vis
af0294e
@maxcabrajac
Unify {visit,walk}_generic_param
b5f5634
@maxcabrajac
Unify walk_crate
7cccfb5
@maxcabrajac
Add visit_attr_args and Unify walk_attr_args
3370623
@maxcabrajac
Add {visit,walk}_safety
bb9dff5
@maxcabrajac
Unify walk_ty
28ac585
@maxcabrajac
Unify walk_assoc_item_constraint
4673554
@maxcabrajac
Unify walk_mac_call
1751802
@maxcabrajac
Unify walk_attribute
d70fb48
@maxcabrajac
Unify {visit,walk}_foreign_mod
de7cf83
@maxcabrajac
Unify {visit,walk}_macro_def
acfa04c
@maxcabrajac
Unify {visit,walk}_ty_alias_where_clauses
dfe7065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxcabrajac @rustbot @rust-log-analyzer @clubby789 @jieyouxu