UnsafeCell::raw_get: use raw pointer self type #118806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
RalfJung
added
the
I-types-nominated
|
I can't think of any issues with this and believe it to be fine to go ahead with this🤔 @compiler-errors or @nikomatsakis may have more to say here. |
|
r=me on implementation modulo sign-offs you think are needed. |
RalfJung
added
T-lang
Mark-Simulacrum
added
S-waiting-on-author
lcnr
added
the
needs-fcp
RalfJung
added
I-libs-api-nominated
|
We discussed this in today's @rust-lang/libs-api meeting, and decided that we want to wait to see what happens with rust-lang/rfcs#3519 and see how that feature ends up stabilizing, before considering this proposal further. |
4 tasks
|
All right, closing the PR then. |
7 tasks
dtolnay
removed
I-lang-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in the day we made this an associated function to avoid relying on raw-ptr self types. I'd like to know if that is still a concern -- I hope we can stabilize #74265 and #71146 soon, and while strangely those do not require the
arbitrary_self_typesfeature, I would think that for the compiler and type system those are very similar cases. So I'd like to see if we are comfortable having stable methods with raw pointer self types. I expect this will need t-lang FCP (and t-libs-api), and also t-types involvement.So @rust-lang/types, what are your thoughts here? This has to pass by you before we send it to the top-level teams; I don't know if we should make one big FCP for all 3 teams or how else t-types should best be involved here.