Fix undefined behavior reported by miri when reading or writing slices #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many methods in the slice or array api take a pointer to the first element and then use that pointer to read or write multiple lanes. This is undefined behavior according to miri since pointer is only valid for a single element. The fix is to use the `as_ptr`/`as_mut_ptr` methods of the slice, which gives a pointer to the whole slice and also leads to nicer code.
|
It's not yet possible to run the whole testsuite with miri as the code also uses many llvm or platform intrinsics, which are not supported. All tests that include This also enables successfully running the arrow-rs tests with its |
jhorstmann
commented
Jul 10, 2023
| @@ -61,6 +61,7 @@ macro_rules! impl_from_array { | |||
| mod [<$id _from>] { | |||
| use super::*; | |||
| #[test] | |||
| #[cfg_attr(miri, ignore)] | |||
There was a problem hiding this comment.
This test itself does something weird and I don't have a good idea what the intention here was. I'm open to re-enabling it, the benefit of ignoring it is that cargo miri test -- array fully passes.
|
This CI really needs to be ported from Travis to GHA. |
I can look into that. Very early version in my fork |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many methods in the slice or array api take a pointer to the first element and then use that pointer to read or write multiple lanes.
This is undefined behavior according to miri since pointer is only valid for a single element. The fix is to use the
as_ptr/as_mut_ptrmethods of the slice, which gives a pointer to the whole slice and also leads to nicer code.