Don't pass -lc to Emscripten, it breaks #4002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch,
fails with:
There are quite a few other sets of linker arguments that trigger this problem, but this is the shortest. Applying this patch to rust-libc and overriding the version of libc used in
library/Crates.toml
to use the patched version, I have verified locally that the crash goes away.See:
emscripten-core/emscripten#22742
emscripten-core/emscripten#16680
rust-lang/rust#98155
rust-lang/rust#98303
rust-lang/rust#131885
cc @workingjubilee @sbc100