-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetBSD CI #3965
base: main
Are you sure you want to change the base?
Add NetBSD CI #3965
Conversation
7d1927e
to
f0d2715
Compare
f0d2715
to
2064b7a
Compare
Looks like this assertion in Based on context, it looks like some variadic function in the NetBSD module is tripping up the testing harness. I'm willing to bet it's ...as it's the only function in the entirety of the libc crate that passes a variadic function as a parameter. Potential solutions:
I've gone ahead and opted for 2. at the moment, since I have no experience with the |
075b631
to
5b0164d
Compare
5b0164d
to
b2a4b96
Compare
It appears that adding an exception to the I've temporarily opted to remove the |
Source for changing |
Documentation on https://github.com/NetBSD/src/blob/da7ff22a4ae89b32ca9e90ca20e7d0d434e8cdd2/sys/sys/event.h#L66 |
Documentation that https://github.com/NetBSD/src/blob/da7ff22a4ae89b32ca9e90ca20e7d0d434e8cdd2/sys/sys/ucred.h#L48 |
Documentation that https://github.com/NetBSD/src/blob/da7ff22a4ae89b32ca9e90ca20e7d0d434e8cdd2/sys/net/if_dl.h#L66-L91 |
Documentation of correct |
Looks like there are a ton of CI failures scattered across the NetBSD module--too many for me to try to resolve at the moment. I'll try to knock out some more later this week in this PR. |
Description
This PR adds NetBSD to the CI for both stable and MSRV targets and resolves current build/test failures resulting from NetBSD modules.
Resolves #3890