Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding arc4random* api family for solarish. #3944

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Sep 26, 2024

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@devnexen
Copy link
Contributor Author

@rustbot label stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 26, 2024
@RalfJung
Copy link
Member

RalfJung commented Sep 28, 2024

@tgross35
Copy link
Contributor

Thanks for linking the docs. LGTM but I'll wait for one of the solarish people to double check this, or merge it in another day or two if we don't hear back.

@RalfJung
Copy link
Member

RalfJung commented Sep 28, 2024

@devnexen maybe you can add the docs link to the PR description, so they become part of the commit message.

(As I already told you in multiple past PRs, please write descriptions for your PRs! It makes them much easier to review, and therefore much more likely to be landed. It is not a great practice to throw a piece of code over the fence without saying a single sentence about the what and why and how.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants