Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rate limiting for e-mail verifications #8419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement rate limiting for e-mail verifications #8419

wants to merge 1 commit into from
+177 −62

Commits on Apr 8, 2024

  1. Implement rate limiting for e-mail verifications. 

    This applies a burst of 3 and a refill time of 30 minutes by default
per user. (Not that I can imagine a scenario where we'd ever override
this for a user, but using the same machinery as other user actions is
obviously much simpler.)

I don't love that this ends up essentially prop-drilling the rate
limiter into a bunch of new places, but I don't see an alternative other
than prop-drilling the whole app struct through, which would be worse.

This doesn't address (sorry) per-address rate limiting, but is at least
a reasonable starting point.
    @LawnGnome
    LawnGnome committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    27637ae View commit details
    Browse the repository at this point in the history