feat: add method to set no_default_c/cxx_flags #219
Conversation
Chiichen
changed the title
|
Corresponding bad case issue : Chiichen/libvnc-rs#1 |
| @@ -420,6 +424,18 @@ impl Config { | |||
| self | |||
| } | |||
|
|
|||
| /// Disables the generation of default compiler cxx flags. The default compiler flags may cause conflicts in some cross compiling scenarios. | |||
There was a problem hiding this comment.
You've mixed up the docstrings.
Anyways, there must be a cleaner way without the duplication. What if the same applies for other language targets down the line (Fortran, ASM)
There was a problem hiding this comment.
What's the meaning of cleaner way without the duplication. I think it's necessary to clear the default flags by languages instead of simply cleaning them for all the language targets
There was a problem hiding this comment.
Come on, half the code is s/cxx/c/. At least use something like a mapping no_default_flags that can hold the option for different langs.
Added a set of methods to implement something similar to
no_default_flagsin thecccrate. Issue here #198