-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable adding cmake c flags #102
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! I feel like though that one of the main purposes of this crate is to automatically add the appropriate C flags. With that disabled is there much gained over just simply calling |
@alexcrichton well that is one way to do it. Our (couchbase) build.rs uses the cmake builder quite significantly (https://github.com/couchbaselabs/couchbase-rs/blob/master/couchbase-sys/build.rs#L9) we just found that on windows against visual studio we have to disable the cmake flags in order to get it to compile. (on linux and osx it works fine as in the source right now) |
Could you gist the error you were seeing with the cmake flags? Maybe there's a way to fix this in |
Hello! UPD: In my case it looks like adding /EHs flag fixes the problem, but as to me, it is less clean than just to let package developers do what they wanted to do :) |
Hi! Is this still depending on something to be merged? I have the same issue blocking my workflow esp-rs/esp-mbedtls#15 which can be fixed by disabling the automatically generated cmake c flags. |
Hello, I'm also interested in this modification. I would be satisfied with something like this: #185 |
We are working with a project in which setting any cmake c flags causes cmake to end up with the incorrect set of flags. This adds an option to disable adding the c flags altogether.