-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Android compiler detection for NDK r25 #728
base: main
Are you sure you want to change the base?
Conversation
This commit updates the compiler detection logic for the Android platform to work with NDK r25. This code is largely identical to the corresponding code in rustc/src/bootstrap/cc_detect.rs.
9a441c8
to
4a78d87
Compare
It occurs to me that if this is committed then developers using older versions of Is there a preference between these options? |
Getting the version by parsing the result of You should probably get the path to rustc via the |
Note to self: this shouldn't get merged until after the discussion in rust-lang/rust#103673 is fully resolved. |
Thanks for the feedback. I'm in the middle of putting out some fires but I'll try and get to this ASAP. |
@chriswailes Could we possibly move forward on this PR? It seems rust-lang/rust#105716 landed again. |
@thomcc rust-lang/rust#103673 was closed now. Could you please take a look at this PR? |
This PR would need a rebase |
Do you think this could fix ruffle-rs/ruffle-android#62 ? 🤔 |
This commit updates the compiler detection logic for the Android platform to work with NDK r25. This code is largely identical to the corresponding code in rustc/src/bootstrap/cc_detect.rs.