Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax proconio requirement #67

Open
wants to merge 2 commits into
base: ja
Choose a base branch
from
Open

Relax proconio requirement #67

wants to merge 2 commits into from

Conversation

statiolake
Copy link
Contributor

In the AtCoder server, proconio v0.3.6 is used. However proconio has
been improved since then without changing server-side bahavior. These
changes are released on the v0.3 series.

proconio is developed and maintained for AtCoder, so we can keep its
behavior compatible with the judge server's behavior on v0.3 series. We
can safely relax its requirement from =0.3.6 to ^0.3.6.

@statiolake
Relax proconio requirement
eca85fd 
In the AtCoder server, proconio v0.3.6 is used. However proconio has
been improved since then without changing server-side bahavior. These
changes are released on the v0.3 series.

proconio is developed and maintained for AtCoder, so we can keep its
behavior compatible with the judge server's behavior on v0.3 series. We
can safely relax its requirement from `=0.3.6` to `^0.3.6`.
@statiolake
Remove Cargo.lock
22da97a 
Some entries are out-of-date but we cannot update them because this
branch is broken as a cargo project (for use with cargo-generate). We
are specifying each dependency by `=x.y.z` so basically we can do
without lock file, I think.
@qryxip
Copy link
Member

qryxip commented Mar 22, 2021

AFAIK, Cargo attempts to preserve lock files as possible.
I'm worried about breaking changes in dependencies of dependencies (e.g. syn ^1) that we don't know yet...

@statiolake
Copy link
Contributor Author

Ah... I agree. That can cause a problem.
I removed Cargo.lock because Cargo hadn't automatically updated proconio-derive which proconio had depended on, and it was a correct behavior for Cargo, just as you said. I don't think it's better to specify more precise version in proconio since it works well with older version of proconio-derive as a library, but I'd be happy if I can offer improvements in proconio-derive here. Perhaps I should specify the version of proconio-derive in Cargo.toml or update Cargo.lock partially.

@qryxip
Copy link
Member

qryxip commented Mar 26, 2021

(sorry for late)
I misunderstood. This PR is for ja, not ja-all-enabled.

@qryxip
Copy link
Member

qryxip commented Mar 26, 2021 •
edited
Loading

Then I think it's reasonable to remove Cargo.lock.

@qryxip
Copy link
Member

qryxip commented Mar 27, 2021

Wait, proconio(-derive) still have a lot of dependencies and are possible cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@statiolake @qryxip